Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema for zarr datasources #6434

Merged
merged 5 commits into from
Sep 5, 2022
Merged

Add JSON schema for zarr datasources #6434

merged 5 commits into from
Sep 5, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Aug 30, 2022

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • edit the settings for a zarr dataset (e.g., add https://data-humerus.webknossos.org/data/zarr/scalable_minds/l4dense_motta_et_al_demo/segmentation via the new ZARR import front-end)
  • editing the JSON should work without "invalid JSON" errors

Issues:


  • Ready for review

@philippotto philippotto requested a review from fm3 August 30, 2022 14:03
@philippotto philippotto self-assigned this Aug 30, 2022
…x by including nested errors (important when validating unions)
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me :) I have to say that the error messages are still not particularly readable, but that’s a separate issue I guess.

@philippotto
Copy link
Member Author

I have to say that the error messages are still not particularly readable, but that’s a separate issue I guess.

Yes, that's #5639. Unfortunately, the jsonschema package doesn't really help with readable error messages..
I'd rather put more work into having a form UI so that the user doesn't have to edit the JSON in the first place.

@philippotto philippotto enabled auto-merge (squash) September 5, 2022 08:20
@philippotto philippotto merged commit 893de94 into master Sep 5, 2022
@philippotto philippotto deleted the zarr-json-schema branch September 5, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants