Improve color palette for tree colors #8228
Conversation
📝 WalkthroughWalkthroughThe pull request introduces several updates to the WEBKNOSSOS application, including a new feature for pasting remote URIs from Neuroglancer, asynchronous reading of image files, improved error messages for job management, and the removal of bounding box restrictions for super users. Additionally, it enhances default colors for skeleton trees and fixes multiple bugs related to tree deletion and NML file imports. The integration of Google Analytics has also been removed. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
CHANGELOG.unreleased.md (1)
20-20: Enhance the changelog entry to better reflect the changes and their impactThe current entry "Improved the default colors for skeleton trees" could be more descriptive about the specific improvements and their user impact, especially given that this addresses user feedback about color contrast issues.
Consider expanding the entry to something like:
- Improved the default colors for skeleton trees. [#8228](https://github.com/scalableminds/webknossos/pull/8228) + Enhanced the color palette for skeleton trees to improve contrast between dark and bright colors, making trees more visually distinguishable. [#8228](https://github.com/scalableminds/webknossos/pull/8228)frontend/javascripts/libs/color_generator.ts (1)
Line range hint
71-88: Consider optimizing random color generationThe current implementation shuffles colors for each request. Consider caching the shuffled colors to improve performance when repeatedly requesting random colors.
const ColorGenerator = { + _shuffledCache: null as Vector3[] | null, + distinctColorForId(id: number): Vector3 { return rgbs[(id - 1 + rgbs.length) % rgbs.length]; }, getNRandomColors(n: number): Vector3[] { - let shuffledColors: Vector3[] = []; + // Reset cache if it doesn't exist + if (!this._shuffledCache) { + this._shuffledCache = _.shuffle([...rgbs]); + } + + let result: Vector3[] = []; let remainingColorCount = n; while (remainingColorCount > 0) { // Take the first k colors const batchSize = Math.min(remainingColorCount, rgbs.length); - shuffledColors = shuffledColors.concat(rgbs.slice(0, batchSize)); + result = result.concat(this._shuffledCache.slice(0, batchSize)); remainingColorCount -= batchSize; + + // Reshuffle cache if we need more colors + if (remainingColorCount > 0) { + this._shuffledCache = _.shuffle([...rgbs]); + } } - return _.shuffle(shuffledColors); + return result; }, };
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
CHANGELOG.unreleased.md(1 hunks)frontend/javascripts/libs/color_generator.ts(2 hunks)
🔇 Additional comments (1)
frontend/javascripts/libs/color_generator.ts (1)
68-68: LGTM! Type-safe color mapping implementation
The color mapping implementation correctly:
- Groups RGB values into triplets
- Normalizes values to 0-1 range
- Ensures type safety with Vector3 assertion
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)