Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back scala-collection-compat for Scala 2.12 #8

Open
MaximeKjaer opened this issue Apr 7, 2021 · 0 comments
Open

Add back scala-collection-compat for Scala 2.12 #8

MaximeKjaer opened this issue Apr 7, 2021 · 0 comments

Comments

@MaximeKjaer
Copy link

As per the discussion in #7, where @vincenzobaz wrote:

If my understanding is correct, scala-collection-compat is needed when we compile in 2.12 to use features from the 2.13 standard library (not only collections) in a 2.12 codebase.

Naturally, this dependency is compiled for 2.13 and 3.0.0-RC1 and could be used without cross.
However scio-core depends on algebird-core with .cross(CrossVersion.for3Use2_13) which depends on scala-collection-compat_2.13 which results in conflicts.

I believe that the next step for this is to add a if (is scala 2.12) { depend on it }. But I prefer to do it when I encounter the missing lib rather than now for all modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant