sbt 1.5.0 and Scala 3.0.0-RC2 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeKjaer
approved these changes
Apr 7, 2021
scio-core/src/main/scala/com/spotify/scio/schemas/SchemaMaterializer.scala
Show resolved
Hide resolved
MaximeKjaer
approved these changes
Apr 7, 2021
|
Feel free to merge as soon as the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
sbt-dottyand upgrades to sbt 1.5.0 and Scala 3.0.0-RC2.The biggest difficulty involves library dependencies.
withDottyCompatwhich is now.crossshould not be used on Java dependencies and on all Scala dependencies.I separated the
libraryDependencieswhich contained only Java dependencies from others. Then I also separated the Scala dependencies which require cross versions from those that do not.Many modules still have some conflict issues, but I propose that we fix them iteratively as we work on them as it is a very tedious process to remove ported/non-ported and incompatible bits.
As libraries progressively are ported to Scala 3, the list of cross-versioned dependencies should shrink.