Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce dependencies #34

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

ldemailly
Copy link
Contributor

@ldemailly ldemailly commented Jun 1, 2024

testify pulls in a lot of stuff and you only use a few asserts equal/true etc for which I have a drop in very light replacement (if you want) https://github.com/fortio/assert

ps: yes it's only for tests yet it impacts go.sum, downloads and ... running tests

@ldemailly ldemailly changed the title reduce dependencies/bloat Reduce dependencies Jun 1, 2024
@scalalang2
Copy link
Owner

scalalang2 commented Jun 3, 2024

thanks for the contribution : )
I like this, thx @ldemailly

dependencies of fortio

module fortio.org/assert

go 1.18

dependencies of stretchr/testify

module github.com/stretchr/testify

// This should match the minimum supported version that is tested in
// .github/workflows/main.yml
go 1.17

require (
	github.com/davecgh/go-spew v1.1.1
	github.com/pmezard/go-difflib v1.0.0
	github.com/stretchr/objx v0.5.2
	gopkg.in/yaml.v3 v3.0.1
)

// Break dependency cycle with objx.
// See https://github.com/stretchr/objx/pull/140
exclude github.com/stretchr/testify v1.8.2

@scalalang2 scalalang2 merged commit 961982c into scalalang2:main Jun 3, 2024
3 checks passed
@ldemailly ldemailly deleted the shrink_dependencies branch June 3, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants