Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add life-cycle methods to PostProcessor modifiers #245
base: main
Are you sure you want to change the base?
Add life-cycle methods to PostProcessor modifiers #245
Changes from 9 commits
b7f91b9
898a744
e093bdc
342cf3e
302ba3b
d55f20f
40e1d54
b8005c9
6a45cfa
8ba0ab0
07c886f
9d05586
57984e6
55ed7e2
0bb50a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of
preProcess
andpostProcess
if the modifier could call those methods directly inside ofprocess
? Judging by the implementation, it doesn't look like mdoc does anything betweenpreProcess
,process
andpostProcess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. This is incorrect. Does nothing. I think these calls should be removed. Ok with you? Want to change the
onStart
andonExit
names?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onStart and onExit are fine