Update to Monaco Editor version 0.13.1 #98
Conversation
It's less typesafe but simplifies binding generation.
| ) | ||
| val symbol = jsObject[SymbolInformation] | ||
| symbol.name = denotation.displayName | ||
| // TODO: pretty print `.tpe`: https://github.com/scalameta/scalameta/issues/1479 |
There was a problem hiding this comment.
The issue has since been closed. Not sure if it is relevant anymore.
There was a problem hiding this comment.
I've updated the comment to link to #99
jonas
force-pushed
the
monaco-editor-0.13.1
branch
from
bb466ed
to
75e1ef2
Compare
resolveLocation no longer needs a model to do its work which allows to simplify for-comprehensions in the providers calling it.
Add notes to the modifications of the bindings.
jonas
force-pushed
the
monaco-editor-0.13.1
branch
from
75e1ef2
to
586fcbd
Compare
There was a problem hiding this comment.
Nice! That was a lot of work. Just tried locally and it works great 👍
Are there exciting new features that are unlocked by this upgrade? I can't find release notes for the Monaco editor.
I didn't manage to update to the latest version (0.14.1). The go to definition provider is not able to switch to another file.
That's a shame. Have the editor service internals changed? Can you maybe open a ticket if you have a branch I can try out? I wish Monaco had out of the box support for multi-file workspaces...
| ) | ||
| val symbol = jsObject[SymbolInformation] | ||
| symbol.name = denotation.displayName | ||
| // TODO: pretty print `.tpe`: https://github.com/scalameta/scalameta/issues/1479 |
There was a problem hiding this comment.
I've updated the comment to link to #99
|
Restarted the CI job for 0.13 due to a timeout. In case 0.13 continues to cause problems, I'm happy to drop it and only support sbt 1.0. |
|
I can make a branch with the changes to upgrade to the latest version. The release notes are here https://github.com/Microsoft/monaco-editor/blob/master/CHANGELOG.md |
Also cleans up several places to make it easier to update to a newer version.
I didn't manage to update to the latest version (0.14.1). The go to definition provider is not able to switch to another file.