Fixing shutdown routine #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It grows very tiring to manually update extension.js on every new commit.
laughedelic
commented
Nov 23, 2017
| @@ -282,7 +282,8 @@ class ScalametaLanguageServer( | |||
| } catch { | |||
| case NonFatal(e) => | |||
| onError(e) | |||
| ShutdownResult(-1) | |||
| // FIXME: server shouldn't send shutdown response if there was no shutdown request | |||
| ShutdownResult() | |||
There was a problem hiding this comment.
@olafurpg I think something wrong is happening here. Server shouldn't send a shutdown response on completion request failure.
There was a problem hiding this comment.
lol, no idea how that got there. feel free to remove the whole try/catch, errors get caught and logged on request now.
There was a problem hiding this comment.
Done in f3d9342 (+ same in documentFormattingRequest)
olafurpg
approved these changes
Nov 23, 2017
|
Oh no... 😭 CI release is broken again. Didn't trigger on merge.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
The problem is in the scala-json-rpc way of handling commands (requests) and notifications. It doesn't allow them to have an empty or absent
paramskey:https://github.com/dhpcs/scala-json-rpc/blob/c25cda4b6a39441bbe4ce25f57ab88e3db5ef635/scala-json-rpc/src/main/scala/com/dhpcs/jsonrpc/MessageCompanions.scala#L66-L71
While the LSP spec for
shutdownsays explicitly:Same about
shutdownresponse andexitnotification. These are the only messages in LSP that don't have parameters, so I'm adding a specialreadoverride to handle these messages.