fix: show zero extent references when using pc #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasiaMarek
force-pushed
the
zero-extent-refs
branch
from
e183a61
to
5357b6b
Compare
tgodzik
approved these changes
Jul 12, 2024
| ) | ||
| ) | ||
|
|
||
| // for Scala 3 the symbol in bar reference is missing (<none>) |
There was a problem hiding this comment.
Could we reprort an issue upstrem?
There was a problem hiding this comment.
This won't compile for Scala 3. I think I confused myself by a combination of VirtusLab/scala-cli#2638 and VirtusLab/scala-cli#2226 (or something similar) 😂
|
|
||
| check( | ||
| "case-class", | ||
| """|case class Ma@@in(i: Int) |
There was a problem hiding this comment.
Why add these two tests with no usages? Is this on puspose?
There was a problem hiding this comment.
Initially I added all zero-extent symbols, not only implicits, so it showed some additional refs in those tests, that shouldn't be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.