Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get correct classpath for running debug #6715

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: get correct classpath for running debug #6715

merged 2 commits into from
Aug 29, 2024

Conversation

kasiaMarek
Copy link
Contributor

resolves: #6714

tgodzik
tgodzik requested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change if you have time. I also updated capabilities in Bazel BSP. Will update to the newest nightly once it's out

metals/src/main/scala/scala/meta/internal/metals/debug/server/DebugeeParamsCreator.scala Outdated

for {
classpathString <- buildTargets
.targetClasspath(id, Promise())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we forward cancelPromise from startDebugSession? This would allow us to cancel the classpath request when the user cancels debugging

tgodzik
tgodzik approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the nitpick since it's a small change

@tgodzik tgodzik merged commit 8866100 into scalameta:main Aug 29, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors when executing run code lenses in Bazel project
2 participants
@kasiaMarek @tgodzik