chore: Check name when renaming #7199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that sometimes rename worked on symbols not within the local scope and these checks should help.
kasiaMarek
reviewed
Feb 7, 2025
Comment on lines
+28
to
+31
| def isLocal = | ||
| sym.ownersIterator | ||
| .drop(1) | ||
| .exists(owner => owner.isMethod || owner.isAnonymousFunction) |
There was a problem hiding this comment.
Doesn't symbol simply have something like isLocal? Or does it fail for Scala 2.11?
There was a problem hiding this comment.
There isisLocal but it's not the same as we need. Some of the tests stop passing
kasiaMarek
reviewed
Feb 7, 2025
| owner.isMethod || owner.isAnonymousFunction | ||
| )) // this also works for worksheets, since they are wrapped in `method main` | ||
| val name = sym.decodedName.toString | ||
| def sameName = soughtSymbolNames(name) |
There was a problem hiding this comment.
How does this work with e.g apply or <init>?
There was a problem hiding this comment.
Good catch, I added them to forbidden methods. We could work something out with apply, but I don't really want to tackle it now and it's a rare enough scenario.
mtags/src/main/scala-3/scala/meta/internal/pc/PcRenameProvider.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that sometimes rename worked on symbols not within the local scope and these checks should help.