bugfix: don't propose inaccessible named arg defaults #7202
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
requested changes
Feb 9, 2025
Directly accessing `CompletionResult.ScopeMembers.results` bypasses
accessibility and similar checks. Going through `matchingResults`
ensures we get the same validation we'd get in other scope-based
completion contexts.
Before this patch, the newly added test would propose the invalid
completion
foo(arg = somePackagePrivStr)
harpocrates
force-pushed
the
named-arg-defaults
branch
from
92b983e to
3e5b227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly accessing
CompletionResult.ScopeMembers.resultsbypasses accessibility and similar checks. Going throughmatchingResultsensures we get the same validation we'd get in other scope-based completion contexts.Before this patch, the newly added test would propose the invalid completion