Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny improvements to the build #328

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Tiny improvements to the build #328

merged 1 commit into from
Oct 18, 2024

Conversation

mzuehlke
Copy link
Contributor

  • tell actions/checkout to fetch tags (instead of a 2nd git fetch invocation)
  • use sbt/setup-sbt to be sure sbt is present
  • remove no longer needed plugin sbt-vspp (see https://github.com/esbeetee/sbt-vspp)
  • simplify CI detection in build.sbt

@mzuehlke
Tiny improvements to the build
167804c 
* tell `actions/checkout` to fetch tags (instead of a 2nd `git fetch` invocation)
* use `sbt/setup-sbt` to be sure `sbt` is present
* remove no longer needed plugin `sbt-vspp` (see https://github.com/esbeetee/sbt-vspp)
* simplify CI detection in `build.sbt`
kitbellew
kitbellew approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also review for similar improvements in scalameta and scalafmt?

@kitbellew kitbellew merged commit 0c51ecc into scalameta:main Oct 18, 2024
2 checks passed
@mzuehlke
Copy link
Contributor Author

mzuehlke commented Oct 18, 2024 •
edited
Loading

could you also review for similar improvements in scalameta and scalafmt?

I will

@mzuehlke mzuehlke deleted the build-hygene branch October 18, 2024 12:25
@mzuehlke mzuehlke mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitbellew kitbellew kitbellew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzuehlke @kitbellew