Router: keep then NL cost at 1 even if no space

scalameta · Sep 3, 2024 · c5ecf30 · c5ecf30
1 parent bff727b
commit c5ecf30
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala b/scalafmt-core/shared/src/main/scala/org/scalafmt/internal/Router.scala
@@ -2008,12 +2008,12 @@ class Router(formatOps: FormatOps) {
           Split(Newline, 1),
         )
       case FormatToken(_, _: T.KwThen | _: T.KwDo, _) =>
-        if (style.newlines.sourceIgnored || noBreak()) Seq(
-          Split(Space, 0)
+        val okSpace = style.newlines.sourceIgnored || noBreak()
+        Seq(
+          Split(!okSpace, 0)(Space)
             .withOptimalToken(nextNonCommentSameLineAfter(ft).left),
           Split(Newline, 1),
         )
-        else Seq(Split(Newline, 0))
       // Last else branch
       case FormatToken(_: T.KwElse, _, _) if (leftOwner match {
             case t: Term.If => t.elsep match {

diff --git a/scalafmt-tests/src/test/resources/scala3/OptionalBraces_keep.stat b/scalafmt-tests/src/test/resources/scala3/OptionalBraces_keep.stat
@@ -106,13 +106,12 @@ object a:
      // c1
    }
 >>>
-Idempotency violated
-=> Diff (- obtained, + expected)
-    if reducePattern(caseBindingMap, scrutineeSym.termRef, cdef.pat)(using
--        gadtCtx
--      )
-+        gadtCtx)
-    then {
+object a:
+   if reducePattern(caseBindingMap, scrutineeSym.termRef, cdef.pat)(using
+        gadtCtx)
+   then {
+     // c1
+   }
 <<< if(cond) indentation
 trait A:
   val cond =