Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces: add credentials to public interface #3620

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

kitbellew
Copy link
Collaborator

@kitbellew kitbellew commented Aug 27, 2023

It will presumably help solve scalameta/sbt-scalafmt#108.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment

public final String host;
public final String username;
public final String password;
public final String realm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

realm doesn't seem to be used, do we need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not used in the current implementation, because we pass before the connection. if we figure out how to pass all of credentials, possibly if coursier changes the interface and allows passing them via API rather than coursier.credentials java system property, that will change.

is adding a realm later going to be a breaking binary change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a default value it shouldn't.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case, removing realm for now.

@kitbellew kitbellew merged commit 23f549c into scalameta:master Aug 28, 2023
8 checks passed
@kitbellew kitbellew deleted the 3620 branch August 28, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants