Skip to content
This repository has been archived by the owner on Apr 18, 2020. It is now read-only.

Owner tree work #58

Closed
wants to merge 3 commits into from
Closed

Conversation

DavidDudson
Copy link
Member

Pushing before this gets too big...

A few things:

  1. It's impossible to do purely compile time typeclass related stuff. I hacked around this by listing all generators (Which kind of defeats the purpose of a type class... But seems like its necessary, perhaps scalameta 3.0 can remedy this? I'm getting around a large number of issues by just using Monocle traversals and prisms)
  2. I'm well aware that the number of dependencies is increasing... I feel monocle/cats together are just too good to pass up, and give a lot of flexibility.
  3. Runner is almost redundant. The only part missing now is the actual expansion, which will follow the patterns outlined in WIP: Very early preview of generator merging #45
  4. This patchset introduces prisms to target generators.
  5. I have an outstanding patchset that goes beyond this and adds support for GeneratorContexts. The issue with this is it add more complexity, as we have both Cofree[List, Tree] and Cofree[List, GeneratorContext] in use in the same file.

@DavidDudson DavidDudson added this to the Version 0.1 milestone Jan 29, 2018
@DavidDudson DavidDudson assigned olafurpg and unassigned olafurpg Jan 29, 2018
@DavidDudson DavidDudson requested a review from olafurpg January 29, 2018 15:03
@DavidDudson
Copy link
Member Author

Closing as I will have a new PR for this soon

@DavidDudson DavidDudson closed this Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants