Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FlatPackage as a GeneratorOption. #873

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deprecate FlatPackage as a GeneratorOption. #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b57f6e
Deprecate FlatPackage as a GeneratorOption.
plaflamme Jul 8, 2020
755295b
Run scalafmt.
plaflamme Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ lazy val grpcRuntimeJVM2_12 = grpcRuntime.jvm(Scala212)
lazy val compilerPlugin = (projectMatrix in file("compiler-plugin"))
.settings(commonSettings)
.settings(
scalacOptions ++= (if (!isDotty.value)
Seq(
"-P:silencer:globalFilters=object FlatPackage in object GeneratorOption is deprecated"
)
else Nil),
libraryDependencies ++= Seq(
protocGen.withDottyCompat(scalaVersion.value),
"com.google.protobuf" % "protobuf-java" % protobufCompilerVersion % "protobuf",
Expand Down
4 changes: 4 additions & 0 deletions compiler-plugin/src/main/scala/scalapb/GeneratorOption.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ package scalapb
sealed trait GeneratorOption extends Product with Serializable

object GeneratorOption {
@deprecated(
"Use package-scoped option instead. See https://scalapb.github.io/customizations.html#package-scoped-options.",
"0.11"
)
case object FlatPackage extends GeneratorOption {
override def toString = "flat_package"
}
Expand Down