Support Coordinator table schema migration for the group commit in ConsensusCommitAdmin.upgrade()
#2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `upgrade` schema-loader command
komamitsu
commented
Jul 11, 2024
| @@ -314,6 +325,7 @@ private void dropTablesIfExist() throws ExecutionException { | |||
| transactionAdmin.dropTable(namespace1, TABLE_1, true); | |||
| transactionAdmin.dropNamespace(namespace1, true); | |||
| transactionAdmin.dropCoordinatorTables(true); | |||
| waitForCreationIfNecessary(); | |||
There was a problem hiding this comment.
Added a few waits since I noticed some tests could fail with some underlying storages
josh-wong
approved these changes
Jul 12, 2024
core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitAdmin.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/scalar/db/transaction/consensuscommit/ConsensusCommitAdmin.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Wong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added the group commit feature for the Coordinator table, which adds a new column
tx_child_idstocoordinator.statetable. The column is supposed to be added by default in ScalarDB 4. But, there is no way for users to address the table schema migration at the moment. This PR adds the Coordinator table schema migration inConsensusCommitAdmin.upgrade()so that users can execute the migration via Schema Loader.Related issues and/or PRs
For ScalarDB 3.13 users, https://github.com/scalar-labs/docs-internal-scalardb/pull/130
Changes made
Admin.addNewColumnToTable(tx_child_ids)if the column doesn't exist in the current Coordinator table metadata (without checking the underlying table)Checklist
Additional notes (optional)
What if any PREPARED state records created by ScalarDB 3 remain in tables when the
upgradecommand is executed?The transaction ID of the PREPARE record doesn't have any prefix (e.g.,
a97Zb8Mxg...). The current ScalarDB 4 versionCoordinatordetermines that the transaction ID is created with the group commit feature disabled, and treats it as a normal transaction.Release notes
Support Coordinator table schema migration for the group commit feature in Schema Loader's
upgradecommand.