-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove example configuration file #2422
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conf/database.properties file is linked to in the following docs:
To avoid accidentally creating broken links, how about we delete the sentence For a sample properties file, see [`database.properties`](https://github.com/scalar-labs/scalardb/blob/master/conf/database.properties).
?
@josh-wong Thank you for pointing that out! I didn't know the sample configuration file was referenced in some documents.
Or, can we have the sample configuration file in the doc site? |
Actually, how about if we change the link to the database.properties file that exists in the scalardb-samples repository? That way, users can see the code nicely formatted in GitHub rather than as plaintext: I think we have some docs that point to that properties file also. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
@josh-wong The database.properites deleted in this PR is different from the database.properties you mentioned. |
Description
This PR removes the example configuration file (
conf/database.properties
) because I don’t think we need to keep it for now. If anyone has any objections, I will close this PR.Related issues and/or PRs
N/A
Changes made
conf/database.properties
).Checklist
Additional notes (optional)
N/A
Release notes
N/A