Skip to content

Commit

Permalink
Fix bug in fedopt that causes model delete to fail in fedopt
Browse files Browse the repository at this point in the history
  • Loading branch information
Andreas Hellander committed Dec 16, 2024
1 parent 10a8ca4 commit 5d188d1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fedn/network/combiner/aggregators/fedopt.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ def combine_models(self, helper=None, delete_models=True, parameters=None):
nr_aggregated_models += 1
# Delete model from storage
if delete_models:
self.update_handler.delete_model(
model_update.model_update_id)
self.update_handler.delete_model(model_update)
logger.info("AGGREGATOR({}): Deleted model update {} from storage.".format(
self.name, model_update.model_update_id))
except Exception as e:
Expand Down

0 comments on commit 5d188d1

Please sign in to comment.