Bug/SK-853 | Helper for package ignored in start_session #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahellander
reviewed
May 28, 2024
| return jsonify( | ||
| { | ||
| "success": False, | ||
| "message": "No compute package set. Set compute package before starting session.", | ||
| } | ||
| ) | ||
| if not helper: | ||
| # get helper from compute package | ||
| helper = package["helper"] |
There was a problem hiding this comment.
Wait, it we can do this here, we should be able to do it also on the combiner? In that case - can we completely eliminate the need to set the helper in the session_config and instead have it encoded in the fedn.yaml? Even if we in the future will not always have a package, I think we will always have the concept of a Project where a fedn.yaml is used to configure things.
There was a problem hiding this comment.
I do not completely follow, the package is not used by combiner, sire you could fetch this iformation using the statestore client. Also, this is beyond this PR. This is a small fix.
ahellander
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_session helper in the api was default always numpyhelper, defualt is now "" empty, and will try to fetch helper type from package.