Fix/SK-1181 | Prevent default flag values from always overwriting yaml file in start-v2 #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benjaminastrand
commented
Nov 6, 2024
benjaminastrand
commented
- Previously default values for name, trainer and validator were set using click - which meant they always overwrote the values in yaml file.
- Logic for setting default values is now moved to function body.
- Now, the logic works as presented in the table below. The entries show which value is used in each of the 4 situations.
| Flag\File | Set | Not set |
|---|---|---|
| Set | Flag value | Flag value |
| Not set | File value | Default value |
…flag -n or name in yaml file exist
…field in yaml file exists
benjaminastrand
changed the title
Wrede
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.