Refactor/SK-1225 | Use api/v1 in APIClient start_session #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminastrand
changed the title
niklastheman
approved these changes
Nov 22, 2024
| }, | ||
| verify=self.verify, | ||
| headers=self.headers, | ||
| ) | ||
|
|
||
| if response.status_code == 201: |
There was a problem hiding this comment.
Cool! An improvement could be to indicate to the user what has gone wrong if status code != 201.
There was a problem hiding this comment.
The method will return the result from the first request, so the user already has access to this information.
|
Setting the active helper in |
niklastheman
approved these changes
Nov 25, 2024
niklastheman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
start_sessionnow makes two POST requests in sequence instead of one:host_url/api/v1/sessions- to create a sessionhost_url/api/v1/sessions/start- to start the sessionThe 2nd request is made only if the 1st request returns status code 201, indicating that the session has been created, and the response from the 2nd request is returned. Otherwise, the response from the 1st request is returned.
Also, the method
set_active_modelin APIClient now sets the active helper based on the file extension of the seed model file used (".npz" -> numpyhelper, ".bin" -> binaryhelper)