Skip to content

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Sep 29, 2025

close #3754

@jremy42 jremy42 requested review from a team and remyleone as code owners September 29, 2025 08:22
@github-actions github-actions bot added the rdb Managed MySQL and PostgreSQL issues, bugs and feature requests label Sep 29, 2025
@jremy42 jremy42 force-pushed the feat/rdb_acl_multiple_descriptions branch from e14ff10 to e350e72 Compare September 30, 2025 14:54
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.48%. Comparing base (6fd860d) to head (3e49e37).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/namespaces/rdb/v1/custom_acl.go 94.33% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5017      +/-   ##
==========================================
+ Coverage   57.47%   57.48%   +0.01%     
==========================================
  Files         308      308              
  Lines       67151    67181      +30     
==========================================
+ Hits        38593    38621      +28     
- Misses      27121    27122       +1     
- Partials     1437     1438       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone marked this pull request as draft October 28, 2025 08:00
@jremy42 jremy42 changed the title feat(rdb): support per-rule descriptions in acl add and update docs feat(rdb): support per-rule descriptions in acl add Oct 29, 2025
@jremy42 jremy42 marked this pull request as ready for review October 29, 2025 15:08
@remyleone remyleone added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit 704ebe3 Oct 29, 2025
17 checks passed
@remyleone remyleone deleted the feat/rdb_acl_multiple_descriptions branch October 29, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rdb Managed MySQL and PostgreSQL issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rdb: acl: handle multiple descriptions when adding ACLs

4 participants