Skip to content

fix(Modal): focus on disclosure #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Modal: return focus to disclosure element when closing the modal

@lisalupi lisalupi self-assigned this Jun 16, 2025
@lisalupi lisalupi requested review from a team, johnrazeur and matthprost as code owners June 16, 2025 12:27
@lisalupi lisalupi force-pushed the fix/focus-menu-modal branch from 907e161 to fc1bcbb Compare June 16, 2025 12:33
Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: ab816a8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi changed the title Fix/focus menu modal fix(Modal): focus on disclosure Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (beta@ae8743e). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta    #5260   +/-   ##
=======================================
  Coverage        ?   88.46%           
=======================================
  Files           ?      241           
  Lines           ?     8550           
  Branches        ?     3792           
=======================================
  Hits            ?     7564           
  Misses          ?      986           
  Partials        ?        0           
Files with missing lines Coverage Δ
.../ui/src/components/Modal/components/Disclosure.tsx 92.85% <100.00%> (ø)
packages/ui/src/components/Modal/index.tsx 94.44% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae8743e...ab816a8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants