Improvement/arsn 423 bump dependencies #2266

benzekrimaha · 2024-10-21T15:25:22Z

bert-e · 2024-10-21T15:25:26Z

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2024-10-21T15:26:18Z

Conflict

There is a conflict between your branch improvement/ARSN-423-bump-dependencies and the
destination branch development/8.2.

Please resolve the conflict on the feature branch (improvement/ARSN-423-bump-dependencies).

git fetch && \
git checkout origin/improvement/ARSN-423-bump-dependencies && \
git merge origin/development/8.2

Resolve merge conflicts and commit

git push origin HEAD:improvement/ARSN-423-bump-dependencies

bert-e · 2024-10-21T15:34:52Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

codecov · 2024-10-21T15:41:08Z

Codecov Report

Attention: Patch coverage is 65.07463% with 117 lines in your changes missing coverage. Please review.

Project coverage is 66.58%. Comparing base (233ae61) to head (909eb1a).

Files with missing lines	Patch %	Lines
...orage/metadata/mongoclient/MongoClientInterface.ts	25.71%	26 Missing ⚠️
lib/policyEvaluator/RequestContext.ts	55.76%	23 Missing ⚠️
lib/patches/locationConstraints.ts	81.81%	10 Missing ⚠️
lib/auth/backends/ChainBackend.ts	27.27%	8 Missing ⚠️
lib/network/kmsAWS/Client.ts	71.42%	8 Missing ⚠️
lib/storage/metadata/mongoclient/LogConsumer.js	12.50%	7 Missing ⚠️
lib/s3routes/routesUtils.ts	0.00%	5 Missing ⚠️
lib/metrics/RedisClient.ts	0.00%	4 Missing ⚠️
lib/s3middleware/azureHelpers/mpuUtils.ts	0.00%	4 Missing ⚠️
lib/auth/auth.ts	57.14%	3 Missing ⚠️
... and 12 more

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.2    #2266      +/-   ##
===================================================
+ Coverage            66.45%   66.58%   +0.13%     
===================================================
  Files                  216      216              
  Lines                17443    17452       +9     
  Branches              3570     3619      +49     
===================================================
+ Hits                 11591    11620      +29     
+ Misses                5836     5828       -8     
+ Partials                16        4      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/s3middleware/processMpuParts.ts

lib/policyEvaluator/utils/wildcards.ts

williamlardier · 2024-10-22T07:46:25Z

lib/policyEvaluator/utils/conditions.ts

@@ -279,9 +277,9 @@ export function convertConditionOperator(operator: string): boolean {
            } else {
                return policyValRegex(key);
            }
+            return true;


I think we should return undefined here, because if we reach this stage, it means the "key" was an array and a prefix that is unknown...

tests/unit/algos/list/delimiterMaster.spec.ts

tests/functional/clustering/ClusterRPC.spec.js

lib/models/ObjectMDArchive.ts

lib/models/ObjectMDAmzRestore.ts

lib/models/LifecycleConfiguration.ts

lib/algos/list/delimiter.ts

.github/workflows/tests.yaml

bert-e · 2024-11-19T19:23:29Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

benzekrimaha · 2024-11-19T19:24:48Z

/approve

benzekrimaha · 2024-11-19T19:24:52Z

/wait

bert-e · 2024-11-19T19:24:56Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
2 peers

The following options are set: approve

package.json

Kerkesni · 2025-01-20T13:01:47Z

lib/auth/Vault.ts


-    const { email, ...userInfoWithoutEmail } = authInfo.message.body.userInfo;
+    const { ...userInfoWithoutEmail } = authInfo.message.body.userInfo;

    log.debug('received info from Vault', {
        ...authInfo,


The goal of this was to exclude the email from the info we set in userInfo below, with the new change it's included again.

No the goal was not to exclude it , the value was declared but never used thus causing a lint error

I'm pretty sure the email was removed from the log for security reasons, you check this commit 6374fc8 (the name of the variable also suggests it)

We can try another approach if we want to avoid the linting issue but yes, we should not print PII in the logs, and the auth info has some (the email)

this should do it ?

Suggested change

const { email, ...userInfoWithoutEmail } = authInfo.message.body.userInfo;

const { ...userInfoWithoutEmail } = authInfo.message.body.userInfo;

log.debug('received info from Vault', {

...authInfo,

const { email: _, ...userInfoWithoutEmail } = authInfo.message.body.userInfo;

log.debug('received info from Vault', {

...authInfo,

Issue: ARSN-423

In this commit the code has been updated to match the new uuid require based on the documentation here : https://www.npmjs.com/package/uuid timestamp format has been updated as well from new Timestamp(1, 1651144629) to new Timestamp({ t: 1651144629 , i: 1 }), the remaining changes are lint fixups ( please note that the indentation has been fixed as well automatically using lint --fix) Issue: ARSN-423

In this commit we fix the tests that were failing after the dependencies bumps. Issue: ARSN-423

Issue: ARSN-423

francoisferrand · 2025-01-31T07:48:25Z

README.md


+## Build Status
+
+![badgepub]
+
+## Codecov Status
+
+![codecov]


i think it's the usual practice to keep the badges "displayed" on top of the README file, so they are visible when we open the github repository's page

francoisferrand · 2025-01-31T07:51:14Z

README.md

-[badgepub]: https://circleci.com/gh/scality/Arsenal.svg?style=svg
-[badgepriv]: http://ci.ironmann.io/gh/scality/Arsenal.svg?style=svg&circle-token=c3d2570682cba6763a97ea0bc87521941413d75c
+[badgepub]: https://github.com/scality/Arsenal/actions/workflows/tests.yaml/badge.svg
+[codecov]: https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg?token=X0esXhJSwb


is this token "safe" to share here: where does it come from/what does it give access to?

Just tried without the token, and it seems to work jsut fine: even in a new "private browsing" window, so i guess we can just remove it...

Suggested change

[codecov]: https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg?token=X0esXhJSwb

[codecov]: https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg

francoisferrand · 2025-01-31T07:59:33Z

lib/storage/metadata/mongoclient/MongoClientInterface.ts

@@ -1682,7 +1686,7 @@ class MongoClientInterface {
                // a master or re-delete it in between so place an
                // atomic condition on the PHD flag and the mst
                // version:
-                // eslint-disable-next-line
+                 


uneeded empty line (between a comment and the code it refers to) + space at end of line

Suggested change

francoisferrand · 2025-01-31T08:02:55Z

lib/storage/metadata/mongoclient/MongoClientInterface.ts

+            log.error('could not get list of collections', {
+                method: 'getBucketInfos',
+                error: err,
            });
+            if (err && err instanceof ArsenalError) {
+                return cb(err);
+            }
+            return cb(errors.InternalError);
+        });
    }


bad indent

Suggested change

log.error('could not get list of collections', {

method: 'getBucketInfos',

error: err,

});

if (err && err instanceof ArsenalError) {

return cb(err);

}

return cb(errors.InternalError);

});

}

log.error('could not get list of collections', {

method: 'getBucketInfos',

error: err,

});

if (err && err instanceof ArsenalError) {

return cb(err);

}

return cb(errors.InternalError);

});

}

or wrap ).catch(err => { to better show that there are 2 "nested" promises (catch relates to toArray().then, not to async.eachLimit)

Suggested change

log.error('could not get list of collections', {

method: 'getBucketInfos',

error: err,

});

if (err && err instanceof ArsenalError) {

return cb(err);

}

return cb(errors.InternalError);

});

}

})

).catch(err => {

log.error('could not get list of collections', {

method: 'getBucketInfos',

error: err,

});

if (err && err instanceof ArsenalError) {

return cb(err);

}

return cb(errors.InternalError);

});

francoisferrand · 2025-01-31T08:04:00Z

lib/storage/metadata/mongoclient/MongoClientInterface.ts

                return cb(null, results);
            });
        });
    }

    consolidateData(store, dataManaged) {
-        /* eslint-disable */
+         


extra empty line + space at end of line

francoisferrand · 2025-01-31T08:04:35Z

lib/storage/metadata/mongoclient/MongoClientInterface.ts

@@ -2977,20 +2977,20 @@ class MongoClientInterface {
                    }
                });
            }).then(() => {
-                const bucketStatus = bucketInfo.getVersioningConfiguration();
-                const isVer = (bucketStatus &&
+            const bucketStatus = bucketInfo.getVersioningConfiguration();


same here, weird indent : should wrap then ?

scality deleted a comment from bert-e Oct 21, 2024

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 57632be to 7cfe8b2 Compare October 21, 2024 15:34

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch 3 times, most recently from 75aab28 to 751140a Compare October 22, 2024 07:18

benzekrimaha marked this pull request as ready for review October 22, 2024 07:18

williamlardier reviewed Oct 22, 2024

View reviewed changes

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch 2 times, most recently from 07d79a7 to cb09de6 Compare October 22, 2024 08:23

KillianG reviewed Nov 18, 2024

View reviewed changes

.github/workflows/tests.yaml Outdated Show resolved Hide resolved

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 50b1389 to c175969 Compare November 19, 2024 18:20

scality deleted a comment from bert-e Nov 19, 2024

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from b67e160 to 9cc8a28 Compare November 19, 2024 19:14

scality deleted a comment from bert-e Nov 19, 2024

KillianG reviewed Nov 20, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 19e6264 to 9eafa33 Compare November 28, 2024 15:46

benzekrimaha requested review from KillianG and williamlardier November 28, 2024 15:54

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 9eafa33 to ba7ade2 Compare November 28, 2024 16:07

benzekrimaha requested a review from francoisferrand January 20, 2025 08:59

williamlardier approved these changes Jan 20, 2025

View reviewed changes

Kerkesni reviewed Jan 20, 2025

View reviewed changes

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch 2 times, most recently from 5722c3a to 33e77f0 Compare January 27, 2025 09:57

benzekrimaha and others added 15 commits January 28, 2025 13:06

Bump dependencies

2f92232

Issue: ARSN-423

Adapt config post bump eslint to v9

9b3eb6a

Issue: ARSN-423

Tests fixups after CI failures due to bumps

736f800

In this commit we fix the tests that were failing after the dependencies bumps. Issue: ARSN-423

Md lint fixup

a108a29

Issue: ARSN-423

Bump node version in gha

9b275cb

Issue: ARSN-423

Post reviews fixups

430632d

bump mongodb and adapt code

d8c30fe

changing ubuntu image to fix dependency issue

700ac25

package.json fixups

1df6d6c

md fixups

6137733

ts config

f08a5e8

fixups on code

62fca2a

fixups on test

9e87b15

fixup badgepub

16c81be

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 33e77f0 to 59f54bb Compare January 28, 2025 14:41

fixup post rebase

a3343a4

benzekrimaha force-pushed the improvement/ARSN-423-bump-dependencies branch from 8a3abe6 to a3343a4 Compare January 28, 2025 15:57

fixup lint

909eb1a

francoisferrand reviewed Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement/arsn 423 bump dependencies #2266

Improvement/arsn 423 bump dependencies #2266

benzekrimaha commented Oct 21, 2024 •

edited

Loading

bert-e commented Oct 21, 2024

bert-e commented Oct 21, 2024

bert-e commented Oct 21, 2024

codecov bot commented Oct 21, 2024 •

edited

Loading

williamlardier Oct 22, 2024 •

edited

Loading

bert-e commented Nov 19, 2024

benzekrimaha commented Nov 19, 2024

benzekrimaha commented Nov 19, 2024

bert-e commented Nov 19, 2024

Kerkesni Jan 20, 2025 •

edited

Loading

benzekrimaha Jan 27, 2025 •

edited

Loading

Kerkesni Jan 27, 2025

williamlardier Jan 27, 2025

francoisferrand Jan 31, 2025

francoisferrand Jan 31, 2025

francoisferrand Jan 31, 2025

francoisferrand Jan 31, 2025

francoisferrand Jan 31, 2025 •

edited

Loading

francoisferrand Jan 31, 2025

francoisferrand Jan 31, 2025

	[codecov]: https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg?token=X0esXhJSwb
	[codecov]: https://codecov.io/gh/scality/Arsenal/branch/development/8.1/graph/badge.svg

Improvement/arsn 423 bump dependencies #2266

Are you sure you want to change the base?

Improvement/arsn 423 bump dependencies #2266

Conversation

benzekrimaha commented Oct 21, 2024 • edited Loading

bert-e commented Oct 21, 2024

Hello benzekrimaha,

bert-e commented Oct 21, 2024

Conflict

bert-e commented Oct 21, 2024

Waiting for approval

codecov bot commented Oct 21, 2024 • edited Loading

Codecov Report

williamlardier Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

bert-e commented Nov 19, 2024

Waiting for approval

benzekrimaha commented Nov 19, 2024

benzekrimaha commented Nov 19, 2024

bert-e commented Nov 19, 2024

Waiting for approval

Kerkesni Jan 20, 2025 • edited Loading

Choose a reason for hiding this comment

benzekrimaha Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francoisferrand Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benzekrimaha commented Oct 21, 2024 •

edited

Loading

codecov bot commented Oct 21, 2024 •

edited

Loading

williamlardier Oct 22, 2024 •

edited

Loading

Kerkesni Jan 20, 2025 •

edited

Loading

benzekrimaha Jan 27, 2025 •

edited

Loading

francoisferrand Jan 31, 2025 •

edited

Loading