Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARSN-458: Add action scuba:GetMetricsBatch #2281

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

BourgoisMickael
Copy link
Contributor

@BourgoisMickael BourgoisMickael commented Jan 24, 2025

GetMetricsBatch action is used by identisee

branch 7.70 for vault
and 8.1 for scuba

@bert-e
Copy link
Contributor

bert-e commented Jan 24, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@BourgoisMickael
Copy link
Contributor Author

/approve

@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@BourgoisMickael BourgoisMickael force-pushed the improvement/ARSN-458-scubaGetMetricsBatch branch from 863cdb2 to 78d630b Compare January 24, 2025 18:29
@BourgoisMickael BourgoisMickael changed the base branch from development/7.10 to development/7.70 January 24, 2025 18:29
@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@scality scality deleted a comment from bert-e Jan 24, 2025
@BourgoisMickael BourgoisMickael force-pushed the improvement/ARSN-458-scubaGetMetricsBatch branch from 9cd5087 to 858e5a4 Compare January 30, 2025 13:11
@scality scality deleted a comment from bert-e Jan 30, 2025
@scality scality deleted a comment from bert-e Jan 30, 2025
@scality scality deleted a comment from bert-e Jan 30, 2025
@scality scality deleted a comment from bert-e Jan 30, 2025
@bert-e
Copy link
Contributor

bert-e commented Jan 30, 2025

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 30, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: approve

@scality scality deleted a comment from bert-e Jan 30, 2025
@scality scality deleted a comment from bert-e Jan 30, 2025
@scality scality deleted a comment from bert-e Jan 30, 2025
Copy link

@dvasilas dvasilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be used to differentiate GetMetricsBatch from GetMetrics in monitoring, right ?

Because otherwise I see no need for a different authentication.

@bert-e
Copy link
Contributor

bert-e commented Jan 30, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/7.70

  • ✔️ development/8.1

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4

Please check the status of the associated issue ARSN-458.

Goodbye bourgoismickael.

The following options are set: approve

@bert-e bert-e merged commit 858e5a4 into development/7.70 Jan 30, 2025
5 checks passed
@bert-e bert-e deleted the improvement/ARSN-458-scubaGetMetricsBatch branch January 30, 2025 13:27
@BourgoisMickael
Copy link
Contributor Author

BourgoisMickael commented Jan 30, 2025

This will be used to differentiate GetMetricsBatch from GetMetrics in monitoring, right ?

Because otherwise I see no need for a different authentication.

@dvasilas Yes.

I put it there as the type of the action is checked.

But if we differentiate in monitoring it is also better to differentiate in the permissions as well, but we can document to rather use an action like scuba:GetMetrics* to handle both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants