Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT: Use data && make check synchronous #98

Merged
merged 3 commits into from
Jun 24, 2016
Merged

FT: Use data && make check synchronous #98

merged 3 commits into from
Jun 24, 2016

Conversation

alexandre-merle
Copy link
Contributor

@alexandre-merle alexandre-merle commented Jun 22, 2016 •
edited
Loading

  • Replace request.query by an object data to
    pass to the function
  • Allow using another service than s3 in the
    signingKey
  • Split the check and the backend call for the
    authentification

@alexandre-merle alexandre-merle force-pushed the ft/use-data branch 3 times, most recently from 36061b1 to 3d7a0b9 Compare June 22, 2016 05:57
@ghost
Copy link

ghost commented Jun 23, 2016

There are some parts of this PR that I'm going to remove very soon.
Would it be possible to rework it so that it only introduces the useful bits ? I'll comment on the unnecessary bits.

@ghost
Copy link

ghost commented Jun 23, 2016

Note that the plan to rework the API is described in #102

@alexandre-merle alexandre-merle force-pushed the ft/use-data branch 2 times, most recently from a70a42b to 15e5d17 Compare June 23, 2016 20:06
@alexandre-merle alexandre-merle changed the title FT: Use data & allow custom object FT: Use data && make check synchronous Jun 23, 2016
@alexandre-merle
Copy link
Contributor Author

Updated :) with an synchronous api :)

@alexandre-merle alexandre-merle force-pushed the ft/use-data branch 4 times, most recently from 8cda44f to cc97b63 Compare June 23, 2016 22:19
@alexandre-merle
Copy link
Contributor Author

see http://ci.ironmann.io/gh/scality/Integration/1837

@alexandre-merle
[Auth](ft): Use data object
f39cfb5 
- Replace request.query by an object data to
  pass to the function
@alexandre-merle alexandre-merle force-pushed the ft/use-data branch 2 times, most recently from bf1b9b5 to 1d7d565 Compare June 24, 2016 16:56
LaurenSpiegel
LaurenSpiegel reviewed Jun 24, 2016
View reviewed changes
lib/auth/auth.js
@@ -10,19 +10,15 @@ const constructStringToSignV4 = require('./v4/constructStringToSign');
const convertUTCtoISO8601 = require('./v4/timeUtils').convertUTCtoISO8601;
const crypto = require('crypto');
const vaultUtilities = require('./in_memory/vaultUtilities');


let vault = require('./vault');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why require vault -- let's just set handler.

@alexandre-merle
Copy link
Contributor Author

Updated :)

@alexandre-merle
[Auth](ft): Synchronous check
e92336e 
- Split the check and the backend call for the
  authentification
@alexandre-merle
[Logs](fix): Use better log function
af0828e 
- use debug instead of warn and trace for the
  flow logs
@rahulreddy
Copy link
Collaborator

👍

@LaurenSpiegel LaurenSpiegel mentioned this pull request Jun 24, 2016
Merged
@alexandre-merle
Copy link
Contributor Author

end to end running http://ci.ironmann.io/gh/scality/Integration/1842

@LaurenSpiegel
Copy link
Contributor

👍

@alexandre-merle
Copy link
Contributor Author

end to end passed, dropme removed :)

@rahulreddy rahulreddy merged commit 0a0dd8f into master Jun 24, 2016
@rahulreddy rahulreddy deleted the ft/use-data branch June 24, 2016 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-merle @rahulreddy @LaurenSpiegel @vrancurel