fixups

scality · Apr 30, 2024 · d2ef10a · d2ef10a
1 parent 7e40b9c
commit d2ef10a
Showing 1 changed file with 9 additions and 19 deletions.
diff --git a/lib/IAMClient.js b/lib/IAMClient.js
@@ -297,18 +297,12 @@ class VaultClient {
             Version: '2010-05-08',
             quotaMax: quota,
         };
-        if (this.disableValidation) {
-            if (accountName) {
-                data.AccountName = accountName;
-            }
-        } else {
-            const quotaIsValid = typeof quota === 'number' && !Number.isNaN(Number.parseInt(quota, 10)) && quota > 0;
-            assert(quotaIsValid, 'Quota must be a strictly positive number');
-            if (accountName) {
-                assert(typeof accountName === 'string', 'the account name, if set, should be a string');
-                data.AccountName = accountName;
-            }
-        }
+        const quotaIsValid = typeof quota === 'number' && !Number.isNaN(Number.parseInt(quota, 10)) && quota > 0;
+          assert(this.disableValidation || quotaIsValid, 'Quota must be a strictly positive number');
+          if (accountName) {
+              assert(this.disableValidation || typeof accountName === 'string', 'the account name, if set, should be a string');
+              data.AccountName = accountName;
+          }
         this.request('POST', '/', true, callback, data);
     }
 
@@ -326,9 +320,7 @@ class VaultClient {
         };
 
         if (accountName) {
-            if (!this.disableValidation) {
-                assert(typeof accountName === 'string', 'the account name, if set, should be a string');
-            }
+            assert(this.disableValidation || typeof accountName === 'string', 'the account name, if set, should be a string');
             data.AccountName = accountName;
         }
         this.request('POST', '/', true, callback, data);
@@ -348,10 +340,8 @@ class VaultClient {
         };
 
         if (accountName) {
-            if (!this.disableValidation) {
-                assert(typeof accountName === 'string',
-                'the account name, if set, should be a string');
-            }
+            assert(this.disableValidation || typeof accountName === 'string',
+            'the account name, if set, should be a string');
             data.AccountName = accountName;
         }
         this.request('POST', '/', true, callback, data);