Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing pre-commit checks #45

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Fix failing pre-commit checks #45

merged 2 commits into from
Jul 27, 2023

Conversation

martin-majlis-s1
Copy link
Collaborator

@martin-majlis-s1 martin-majlis-s1 commented Jul 27, 2023

Code quality check is not reliable since it's failing all the time on some strange errors.

go test -v -race -timeout 360s -parallel 4 -count=1 -tags=long_running,"" ./...
Error: pkg/buffer_config/buffer_config.go:23:2: cannot find package "." in:
	/home/runner/work/dataset-go/dataset-go/vendor/github.com/cenkalti/backoff/v4
Error: pkg/buffer/buffer.go:32:2: cannot find package "." in:
	/home/runner/work/dataset-go/dataset-go/vendor/github.com/google/uuid
Error: pkg/client/client.go:44:2: cannot find package "." in:
	/home/runner/work/dataset-go/dataset-go/vendor/github.com/cskr/pubsub
make: *** [Makefile:56: test-all] Error 1
Error: Process completed with exit code 2.

Let's try to fix this.

I have removed dnephin/pre-commit-golang - pre-commit hook - dnephin/pre-commit-golang#98 - since it was failing and it's no longer supported. And it has solved the problem.

Testing

I have rerun pipeline 4 times and it has always succeeded. So I am going to merge it and we will see.

@codecov-commenter
Copy link

Codecov Report

Merging #45 (48b590f) into main (86db63b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files          11       11           
  Lines        1534     1534           
=======================================
  Hits         1156     1156           
  Misses        315      315           
  Partials       63       63           

@martin-majlis-s1 martin-majlis-s1 merged commit aca8af3 into main Jul 27, 2023
@martin-majlis-s1 martin-majlis-s1 deleted the fix-ci-cd-pipeline branch July 27, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants