Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skip-phpstorm-config option to the start command #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+73 −62
Open

Added skip-phpstorm-config option to the start command #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions build-packages/magento-scripts/lib/commands/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ module.exports = (yargs) => {
describe: 'Enable verbose logging',
type: 'boolean',
default: false
})
.option('skip-phpstorm-config', {
alias: 'c',
describe: 'Skip setting PHPStorm config',
type: 'boolean',
default: false
}),
async (args = {}) => {
/**
Expand Down
129 changes: 67 additions & 62 deletions build-packages/magento-scripts/lib/tasks/file-system/create-php-storm-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,79 +4,84 @@ const path = require('path');
const fs = require('fs');

const createPhpStormConfig = () => ({
title: 'Setting PHPStorm config',
task: async ({ config: { phpStorm }, ports }) => {
const { phpLanguageLevel } = phpStorm.php;
const jdbcUrl = `jdbc:mysql://localhost:${ports.mysql}/magento`;
task: (ctx, task) => task.newListr([
{
title: 'Setting PHPStorm config',
skip: (ctx) => ctx.skipPhpstormConfig,
task: async ({ config: { phpStorm }, ports }) => {
const { phpLanguageLevel } = phpStorm.php;
const jdbcUrl = `jdbc:mysql://localhost:${ports.mysql}/magento`;

try {
await setConfigFile({
configPathname: phpStorm.xdebug.path,
template: phpStorm.xdebug.templatePath,
overwrite: true,
templateArgs: {
phpStorm
try {
await setConfigFile({
configPathname: phpStorm.xdebug.path,
template: phpStorm.xdebug.templatePath,
overwrite: true,
templateArgs: {
phpStorm
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during workspace.xml config creation\n\n${e}`);
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during workspace.xml config creation\n\n${e}`);
}

try {
await setConfigFile({
configPathname: phpStorm.php.path,
template: phpStorm.php.templatePath,
overwrite: true,
templateArgs: {
phpLanguageLevel
try {
await setConfigFile({
configPathname: phpStorm.php.path,
template: phpStorm.php.templatePath,
overwrite: true,
templateArgs: {
phpLanguageLevel
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during php.xml config creation\n\n${e}`);
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during php.xml config creation\n\n${e}`);
}

try {
await setConfigFile({
configPathname: phpStorm.database.dataSourcesLocal.path,
template: phpStorm.database.dataSourcesLocal.templatePath,
overwrite: true,
templateArgs: {
phpStorm
try {
await setConfigFile({
configPathname: phpStorm.database.dataSourcesLocal.path,
template: phpStorm.database.dataSourcesLocal.templatePath,
overwrite: true,
templateArgs: {
phpStorm
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during dataSources.local.xml config creation\n\n${e}`);
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during dataSources.local.xml config creation\n\n${e}`);
}

try {
await setConfigFile({
configPathname: phpStorm.database.dataSources.path,
template: phpStorm.database.dataSources.templatePath,
overwrite: true,
templateArgs: {
phpStorm,
jdbcUrl
try {
await setConfigFile({
configPathname: phpStorm.database.dataSources.path,
template: phpStorm.database.dataSources.templatePath,
overwrite: true,
templateArgs: {
phpStorm,
jdbcUrl
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during dataSources.xml config creation\n\n${e}`);
}
});
} catch (e) {
throw new Error(`Unexpected error accrued during dataSources.xml config creation\n\n${e}`);
}

if (!await pathExists(path.resolve('./.idea/dataSources'))) {
await fs.promises.mkdir(path.resolve('./.idea/dataSources'));
}
if (!await pathExists(path.resolve('./.idea/dataSources'))) {
await fs.promises.mkdir(path.resolve('./.idea/dataSources'));
}

try {
await setConfigFile({
configPathname: phpStorm.inspectionTools.path,
template: phpStorm.inspectionTools.templatePath,
overwrite: true,
templateArgs: {}
});
} catch (e) {
throw new Error(`Unexpected error accrued during Project_Default.xml config creation\n\n${e}`);
try {
await setConfigFile({
configPathname: phpStorm.inspectionTools.path,
template: phpStorm.inspectionTools.templatePath,
overwrite: true,
templateArgs: {}
});
} catch (e) {
throw new Error(`Unexpected error accrued during Project_Default.xml config creation\n\n${e}`);
}
}
}
}
])
});

module.exports = createPhpStormConfig;