Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.2.1 #276

Merged
merged 4 commits into from
Jul 2, 2023
Merged

v0.2.1 #276

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57a1742
v0.2.0
Schwad Jul 2, 2023
d3e9ddd
If we require bloops we need it as a runtime dependency
Schwad Jul 2, 2023
a27b949
Lint
Schwad Jul 2, 2023
572ca7c
v0.2.1
Schwad Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
## [Unreleased]

Here we write upgrading notes for brands. It's a team effort to make them as
straightforward as possible.

### Added
- #-some-pr-number <description> @author-of-pr

### Changed

### Fixed

## [0.2.0] - 2022-07-02

- First batch of functionality. Will aggressively track to changelog from here on out.

## [0.1.0] - 2022-02-09

- Initial release
2 changes: 1 addition & 1 deletion lib/scarpe/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

class Scarpe
VERSION = "0.1.0"
VERSION = "0.2.0"
end
1 change: 1 addition & 0 deletions scarpe.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Gem::Specification.new do |spec|

spec.add_dependency "logging", "~>2.3.1"
spec.add_dependency "webview_ruby", "~>0.1.1"
spec.add_dependency "bloops", "~>0.5"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught this. Since we require the external dependency in scarpe.rb We'll need it as a runtime dependency. Otherwise folks without this will get

`require': cannot load such file -- bloops (LoadError)
	from <internal:/opt/rubies/3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /Users/schwad/.gem/ruby/3.2.0/gems/scarpe-0.2.0/lib/scarpe.rb:24:in `<top (required)>'
	from <internal:/opt/rubies/3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from <internal:/opt/rubies/3.2.0/lib/ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:85:in `require'
	from /Users/schwad/.gem/ruby/3.2.0/gems/scarpe-0.2.0/exe/scarpe:94:in `<top (required)>'
	from /Users/schwad/.gem/ruby/3.2.0/bin/scarpe:25:in `load'
	from /Users/schwad/.gem/ruby/3.2.0/bin/scarpe:25:in `<main>'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They used to have runtime dependencies and development dependencies. But I'm not sure they do any more? We'll have the same problem with logging if you're right, since that's also a runtime dependency.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could try building and running without the "bundle exec" from a locally-installed gem. But I was pretty sure that worked. And even our really basic dependencies like webview just use add_dependency, and have since the beginning.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's "add_dependency" and "add_development_dependency" now? Is that wrong?

I secretly pushed 0.2.0 to test it locally when I found this bug running "Scarpe examples/foo.rb". Fails on the require.

So will need to bump to 0.2.1 and try it out again with this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever deploy strategy for bloops fork btw

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I think it used to be "add_runtime_dependency" vs "add_development_dependency". I thought it was all just "add_dependency" now (a dev-only dependency goes in your Gemfile) but I might be wrong.


# For more information and examples about making a new gem, check out our
# guide at: https://bundler.io/guides/creating_gem.html
Expand Down
Loading