Use a single Scarpe::App instance as self nearly everywhere #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
force-pushed
the
shoes_api_self
branch
5 times, most recently
from
19b60b6
to
2186904
Compare
noahgibbs
force-pushed
the
shoes_api_self
branch
3 times, most recently
from
329f52c
to
3578d0f
Compare
noahgibbs
commented
Jul 5, 2023
| require "nokogiri" | ||
|
|
||
| class Scarpe::Widget | ||
| def download(url) |
There was a problem hiding this comment.
Note to me: make sure we have a test for download. Is this on the right class?
|
Notes from review: Add test that uses ivar properly, including set inside stack and used outside it. |
|
Will try to rewrite some examples without globals after |
Make display properties properly inheritable Move DocumentRoot special behavior into app, make it 'just a Flow' Remove unused app-option override code in ControlInterface
|
Okay. Added the new tests, will merge after CI builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #136 for initial bug report. See https://github.com/scarpe-team/scarpe/wiki/ShoesSlotsSelf.md for a description of the preferred behaviour.
This should fix #136 when complete and merged.
Description
This PR passes the Shoes::App instance as self to relevant APIs.
However, I did not do this for Shape. Shape is going to require a more extensive rework. I'll file a bug for it.
Checklist