PR for :emphasis property in issue#520 #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahgibbs
reviewed
Jan 4, 2024
noahgibbs
approved these changes
Jan 4, 2024
|
Looks good. Assuming the tests pass (I expect they will) I'm cool with merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
for #520
This PR introduces support for the :emphasis style within the text rendering functionalities of Scarpe. It enables the italicization of text elements such as em, span, and other applicable tags based on Shoes conventions.
Motivation and Context:
Feature Enhancement: By incorporating support for the :emphasis style, Scarpe gains the ability to properly italicize text where necessary, improving visual representation and flexibility in text styling.
Alignment with Specifications: This change aligns Scarpe's text styling capabilities with the expected behavior specified for the :emphasis style in Shoes. It allows for three settings: "normal," "oblique," and "italic," enabling versatile text formatting.
Checklist