Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the api config runtime-configurable #152

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Make the api config runtime-configurable #152

wants to merge 2 commits into from

Conversation

tstenner
Copy link
Collaborator

@tstenner tstenner commented Oct 4, 2021

  • replace the map-based INI reader with a callback based function
  • move default values to the variable initializers, i.e. a default-construct api_config has sane defaults
  • add function api_config::set_option(), could be exported to the C API in the future
  • add optional bool parameter to skip loading settings from a file (needed for the unit test right now)
  • throw errors on some invalid settings

@tstenner
Make the api config runtime-configurable
ac706f7 
* replace the map-based INI reader with a callback based function
* move default values to the variable initializers
* add function api_config::set_option()
* add optional bool parameter to skip loading settings from a file
* throw errors on some invalid settings
@tstenner tstenner added the discussion Ideas that need discussion label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
discussion Ideas that need discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tstenner