Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the drawnow from line 243 to 247 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UgoBruzadin
Copy link

Changed the drawnow line to increase plotting speed. Gain about 50% or more in plotting speed, plots all head models at the same time.

Changed the drawnow line to increase plotting speed. Gain about 50% or more in plotting speed.
@lucapton
Copy link
Collaborator

lucapton commented Aug 8, 2020

@UgoBruzadin Thank you for submitting this fix. It seem like a good change.

@nucleuscub @arnodelorme This code was originally taken from pop_selectcomps in EEGLAB therefore this change should likely go there as well in addition to being merged into ICLabel which has a local copy of viewprops. I've confirmed this fix speeds the plotting up significantly and works without issue on Windows 10. Would one of you check to see that this works on any other platforms that EEGLAB supports? Once I get your confirmation, I'll merge this and copy the change over to ICLabel as well.

@UgoBruzadin
Copy link
Author

UgoBruzadin commented Aug 13, 2020

@lucapton No problem! I'm glad to help. I hope it's useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants