Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments in strings.txt #32

Closed
wants to merge 4 commits into from
Closed

Allow comments in strings.txt #32

wants to merge 4 commits into from

Conversation

josephearl
Copy link

Ignore all lines starting with a # character.

@scelis
Copy link
Owner

scelis commented Jul 2, 2013

I don't really understand the reasoning behind forking and renaming the project.

As for allowing comments in strings.txt, this has definitely been something I have wanted to do (see issue #8). However, since twine needs to be able to read in and then write out the strings.txt file, twine needs to understand any comments so that they can be preserved in this process (for example, when twine executes the consume-lox-drop command, your commit will cause any existing comments in the strings.txt file to be lost.

Thus, stringsfile.rb needs a way to parse and save all comments in the read method and then write them all out again in the "write" method.

@scelis scelis closed this Jul 2, 2013
@josephearl
Copy link
Author

Sorry, wrong branch. Renaming was for something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants