-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase previous Blink fix #4 #1002
Open
macluiggy
wants to merge
16
commits into
schacon:master
Choose a base branch
from
macluiggy:rebase-blink
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hola esto sirve para notificar @schacon de esta forma el notificado se subcribira automaticamente y recibira un notificacion de este pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation from #998 pull request
This PR replaces #2 (#2) (sale repetido, pero si lo editas, sale de forma mas larga, esto es debido a que si bien esta bien escrito, no es necesario ponerlo asi, ya que esta referencia se encuentra en el repositorio original) s rebased branch instead
you should also see tonychacon#1 (poner#1 no es lo mismo) and of course schacon/kidgloves#2
tough nothing compares to schacon/kidgloves#1
check this #1001 (#1001) (#1001)
vamos a explicar
para referenciar un issue que sea original a este repositorio, solo hay que poner #num, ej: #1
para referenciar un issue que sea de un fork, hay que poner username#num, ej: tonychacon#1
para referenciar un issue de un reposiorio distinto hay que poner username/repo#num, ej: schacon/kidgloves#2
Tambien puedes referenciar commits de la misma forma que se hace los issues y pull request, solo seria poner el codigo SHA-1 del commit
05b45b6
macluiggy/boilerplate-express#1588f8d4aff85911f8593b5a2b8c6bd1ef1ceada