scxtop: Add async symbolization #2648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hodgesds
requested review from
xerothermic,
htejun,
JakeHillion,
etsal,
likewhatevs and
yaakov-stein
hodgesds
changed the title
Add separate thread from symbolization to remove symbolization from the TUI render thread. This fixes stalls in TUI rendering from symbolization. Signed-off-by: Daniel Hodges <[email protected]>
hodgesds
force-pushed
the
scxtop-async-symbolization
branch
from
f384036 to
13ee79b
Compare
JakeHillion
reviewed
Aug 20, 2025
| let (resp_tx, resp_rx) = mpsc::channel::<SymbolizationResponse>(); | ||
|
|
||
| // Spawn the worker thread | ||
| thread::spawn(move || { |
There was a problem hiding this comment.
Might be worth switching to tokio::spawn and tokio::mpsc for uniformity, you can still do a receive in a sync context with try_recv which I think is appropriate for this use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add separate thread from symbolization to remove symbolization from the TUI render thread. This fixes stalls in TUI rendering from symbolization.