ci: implement selective test matrix based on changed files #2958
+393
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add change detection logic to list-integration-tests.py - Build dependency graph from Cargo metadata - Filter test matrix to only affected schedulers - Test all schedulers when core files or libraries change - Add local testing script and documentation This reduces CI time for PRs that only touch specific schedulers. Technical changes: - Added get_changed_files() to detect file changes in PR context - Added should_test_all_schedulers() to categorize changes - Added build_scheduler_dependency_map() to track Cargo dependencies - Added get_affected_schedulers() to determine which schedulers to test - Modified main() to filter the scheduler list based on changes - Preserved backward compatibility: non-PR contexts test everything Examples: - PR changing only scx_chaos: tests 1 scheduler (85-90% CI time saved) - PR changing scx_utils: tests all schedulers (conservative) - PR changing scx_rustland_core: tests scx_rustland and scx_rlfifo only
|
Not sure how to test this besides landing really, but this should significantly speed up CI. |
JakeHillion
reviewed
Oct 28, 2025
Comment on lines
+177
to
+192
| core_patterns = [ | ||
| "rust/scx_utils/", | ||
| "rust/scx_stats/", | ||
| "rust/scx_cargo/", | ||
| "rust/scx_arena/", | ||
| "rust/scx_userspace_arena/", | ||
| "rust/scx_bpf_compat/", | ||
| "rust/scx_raw_pmu/", | ||
| "scheds/include/", | ||
| ".github/", | ||
| ".nix/", | ||
| "Cargo.toml", # Root workspace Cargo.toml | ||
| "Cargo.lock", | ||
| "meson.build", | ||
| "kernel-versions.json", | ||
| ] |
There was a problem hiding this comment.
Do you think we could invert this? I wonder whether it would be better to say that changes in scheds/rust don't necessarily run everything, but every other change does. This list scares me a bit!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces CI time for PRs that only touch specific schedulers.
Technical changes:
Examples: