scxtop: Refactor process/thread rendering into separate module (Phase 1) #2959
+837
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract process and thread rendering logic from the monolithic app.rs
into a new dedicated render module. This is Phase 1 of a larger
refactoring effort to improve maintainability of the scxtop codebase.
Changes:
- Created src/render/mod.rs and src/render/process.rs
- Introduced ProcessRenderer struct with static methods
- Extracted create_table_header_and_constraints() (~40 lines)
- Extracted render_process_table() (~100 lines)
- Extracted render_thread_table() (~100 lines)
- Modified src/app.rs
- Removed duplicate rendering implementation
- Delegated to ProcessRenderer for process/thread rendering
- Updated method signatures to return new events_list_size value
to avoid borrowing conflicts
- Modified src/lib.rs
- Added pub mod render
- Exported Column type for test access
- Added tests/render_process_tests.rs
- Tests for table header generation
- Tests for process table rendering
- Tests for thread table rendering
- Uses ratatui TestBackend for integration-style testing
- Created helper functions for test data creation
Signed-off-by: Daniel Hodges <[email protected]>
JakeHillion
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract process and thread rendering logic from the monolithic app.rs into a new dedicated render module. This is Phase 1 of a larger refactoring effort to improve maintainability of the scxtop codebase.
Changes:
Created src/render/mod.rs and src/render/process.rs
Modified src/app.rs
Modified src/lib.rs
Added tests/render_process_tests.rs