scxtop: Refactor network rendering into separate module (Phase 3) #2961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract memory view rendering logic from the monolithic app.rs into a
new dedicated render module. This is Phase 2 of the larger refactoring
effort to improve maintainability of the scxtop codebase.
Changes:
- Created src/render/memory.rs
- Introduced MemoryRenderer struct with static methods
- Extracted render_memory_view()
- Extracted render_memory_summary()
- Extracted render_memory_table()
- Modified src/app.rs
- Removed duplicate memory rendering implementation
- Delegated to MemoryRenderer for all memory-related rendering
- Cleaned up unused imports (memory column functions)
- Modified src/render/mod.rs
- Added pub mod memory
- Exported MemoryRenderer
- Added tests/render_memory_tests.rs
- Tests for memory view rendering
* Basic rendering with default values
* Swap usage scenarios (0%, 50%)
* Low/high memory pressure scenarios
* Small terminal area handling
- Tests for memory summary rendering
* Basic summary rendering
* Multiple theme support verification
- Uses ratatui TestBackend for integration-style testing
- Created helper function create_test_mem_stats() with realistic values
Signed-off-by: Daniel Hodges <[email protected]>
Extract all network rendering logic (~687 lines) from app.rs into a new NetworkRenderer module in src/render/network.rs. This includes: - Full network view with interface table and traffic charts - Network summary for default view (top 5 interfaces) - Historical traffic visualization (bytes and packets) - Dual-axis mirrored charts (RX negative, TX positive) - Delta calculation for per-second rates - Comprehensive error handling and edge cases Add extensive test coverage with 13 tests covering: - Basic rendering, localization, themes - Edge cases: no interfaces, zero/high traffic, many interfaces - Small terminal compatibility - Multiple tick rates Signed-off-by: Daniel Hodges <[email protected]>
hodgesds
force-pushed
the
scxtop-refactor-phase3
branch
from
62915d7 to
b2396e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract all network rendering logic (~687 lines) from app.rs into a new
NetworkRenderer module in src/render/network.rs. This includes:
Add extensive test coverage with 13 tests covering: