Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing '_display_code_snippet' variable #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing '_display_code_snippet' variable #186

wants to merge 1 commit into from

Conversation

ianfp
Copy link

@ianfp ianfp commented Sep 22, 2017

This is required for compatibility with Symfony 3.3.9 (and earlier?). See

symfony/symfony#24265

Add missing '_display_code_snippet' variable
af96620 
This is required for compatibility with Symfony 3.3.9 (and earlier?)
sonnylloyd
sonnylloyd approved these changes Oct 21, 2017
View reviewed changes
Copy link

@sonnylloyd sonnylloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution fixed the issue stated

@kopaygorodsky
Copy link

Would be nice to have this fix in master.

@kick-the-bucket
Copy link

About the failing build:
This bundle states that it supports PHP 5.5.0 || ^7.0, but strangely has a composer.lock commited with a lot of dependencies, that need at least 5.5.9 or even 5.6.
For a library trying to support different platforms and package versions the composer.lock file should either be omitted at all or generated using the lowest PHP version supported.

mauroaltamura pushed a commit to mauroaltamura/JMSJobQueueBundle that referenced this pull request Dec 2, 2022
@psrpinto
Transform form data in a DataTransformer (schmittjoh#186)
473c49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonnylloyd sonnylloyd sonnylloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ianfp @kopaygorodsky @kick-the-bucket @sonnylloyd