-
Notifications
You must be signed in to change notification settings - Fork 100
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #113 from benjamindulau/has_class_permission_expre…
…ssion Added a "hasClassPermission" Expression for checking classe scope permissions
- Loading branch information
Showing
4 changed files
with
160 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
Security/Acl/Expression/HasClassPermissionFunctionCompiler.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * Copyright 2011 Johannes M. Schmitt <[email protected]> | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace JMS\SecurityExtraBundle\Security\Acl\Expression; | ||
|
|
||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\ConstantExpression; | ||
|
|
||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\VariableExpression; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\FunctionExpression; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\ExpressionCompiler; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Compiler\Func\FunctionCompilerInterface; | ||
|
|
||
| class HasClassPermissionFunctionCompiler implements FunctionCompilerInterface | ||
| { | ||
| public function getName() | ||
| { | ||
| return 'hasClassPermission'; | ||
| } | ||
|
|
||
| public function compilePreconditions(ExpressionCompiler $compiler, FunctionExpression $function) | ||
| { | ||
| $compiler->verifyItem('token', 'Symfony\Component\Security\Core\Authentication\Token\TokenInterface'); | ||
| } | ||
|
|
||
| public function compile(ExpressionCompiler $compiler, FunctionExpression $function) | ||
| { | ||
| $compiler | ||
| ->compileInternal(new VariableExpression('permission_evaluator')) | ||
| ->write('->hasPermission(') | ||
| ->compileInternal(new VariableExpression('token')) | ||
| ->write(", new Symfony\Component\Security\Acl\Domain\ObjectIdentity(") | ||
| ->compileInternal($function->args[0]) | ||
| ->write(", -1), ") | ||
| ; | ||
|
|
||
| if ($function->args[1] instanceof ConstantExpression) { | ||
| $compiler->write(var_export(strtoupper($function->args[1]->value), true).')'); | ||
|
|
||
| return; | ||
| } | ||
|
|
||
| $compiler | ||
| ->write('strtoupper(') | ||
| ->compileInternal($function->args[1]) | ||
| ->write('))') | ||
| ; | ||
| } | ||
| } |
40 changes: 40 additions & 0 deletions
40
Tests/Security/Acl/Expression/HasClassPermissionFunctionCompilerTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| namespace JMS\SecurityExtraBundle\Tests\Security\Acl\Expression; | ||
|
|
||
| use JMS\SecurityExtraBundle\Security\Acl\Expression\HasClassPermissionFunctionCompiler; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\VariableExpression; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\ConstantExpression; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\Ast\FunctionExpression; | ||
| use JMS\SecurityExtraBundle\Security\Authorization\Expression\ExpressionCompiler; | ||
|
|
||
| class HasClassPermissionFunctionCompilerTest extends \PHPUnit_Framework_TestCase | ||
| { | ||
| private $compiler; | ||
|
|
||
| public function testCompile() | ||
| { | ||
| $source = $this->compiler->compile(new FunctionExpression('hasClassPermission', | ||
| array(new VariableExpression('foo'), new ConstantExpression('VIEW')))); | ||
|
|
||
| $this->assertContains( | ||
| "\$context['permission_evaluator']->hasPermission(\$context['token'], new Symfony\\Component\\Security\\Acl\\Domain\\ObjectIdentity(\$context['foo'], -1), 'VIEW');", | ||
| $source); | ||
| } | ||
|
|
||
| public function testCompileUpperCasesPermissions() | ||
| { | ||
| $source = $this->compiler->compile(new FunctionExpression('hasClassPermission', | ||
| array(new VariableExpression('foo'), new ConstantExpression('view')))); | ||
|
|
||
| $this->assertContains( | ||
| "\$context['permission_evaluator']->hasPermission(\$context['token'], new Symfony\\Component\\Security\\Acl\\Domain\\ObjectIdentity(\$context['foo'], -1), 'VIEW');", | ||
| $source); | ||
| } | ||
|
|
||
| protected function setUp() | ||
| { | ||
| $this->compiler = new ExpressionCompiler(); | ||
| $this->compiler->addFunctionCompiler(new HasClassPermissionFunctionCompiler()); | ||
| } | ||
| } |