Fixed the GetItemExpression #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure whether we should not completely remove this feature. I've never used it myself, and it seems a bit too much for expressions; after all, you shouldn't start to program in there. Could you maybe share your use-case? |
|
The only reason why I use it currently is because I'm doing a weird hack for now to be able to workaround the missing visitors rewriting the AST. But it should either be fixed or removed. Keeping it totally broken does not make sense. On the other hand, if your application uses arrays to store the values instead of using objects with getters and setters, it may make sense to allow accessing items. However, should the item key really be an expression in the parser ? Allowing only strings or integers may be better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently totally unusable: adding it in the expression throws a fatal error because of the missing interface, and its compilation is totally broken.