feat(handler): Create JsonSerializable handler #1486
+141
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a very nice addition. I think that it should be an opt in feature as it might be seen as a BC break if suddenly we start using it to decide what json serializeation should look |
scyzoryck
force-pushed
the
serialisable-handler
branch
from
9c5e363
to
5a93aff
Compare
scyzoryck
force-pushed
the
serialisable-handler
branch
from
5a93aff
to
3959d4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
PHP provides nice interface to serialize data to Json, that is also fast. It works only in the serialization direction, there is no way to handle deserialization with it. In our benchmarks, after adding it to
Authorclass we gained 15% faster serialization.TODOs: