Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for Node no longer exists #871

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

Deltachaos
Copy link

@Deltachaos Deltachaos commented Feb 7, 2018

The isset($attributes[$name]) sometimes also throws a notice like described in https://bugs.php.net/bug.php?id=75168

This introduces the workaround form #817 also in this place. We cannot use the isNull method here because of the todo mark in this method.

Q A
Bug fix? yes
New feature? no
Doc updated no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #817
License Apache-2.0

@goetas
Copy link
Collaborator

goetas commented Feb 7, 2018

any way to test this?

@goetas goetas self-assigned this Mar 23, 2018
@goetas goetas added this to the v1.12 milestone Mar 23, 2018
@goetas goetas changed the base branch from master to 1.x May 3, 2018 15:58
@goetas
Copy link
Collaborator

goetas commented May 3, 2018

Can you help here to reproduce the issue?

@goetas goetas modified the milestones: v1.12, v1.x May 25, 2018
@Deltachaos
Copy link
Author

I do not have the original case that caused this problem anymore

@Kalyse
Copy link

Kalyse commented Nov 3, 2020

I can't provide a test case, but after applying the patch manually to my code, this resolves my issue also.

For some unknown reason to me, the issue was the visitProperty was receiving an empty SimpleXMLElement without a name. I have no idea how that is possible, but for obviousness,

if (isset($attributes[$name])) { fails, because of no name. That's why the warning is thrown. I can't provide a test case, no more than the author in 2018 could, but can confirm this does fix the underlying issue for me.

@goetas
Copy link
Collaborator

goetas commented Nov 8, 2020

I understand that for some cases might be a problem, i'm wondering if this is a bug or an issue with the configurations in your project, and IMO the only way to figure out it is to find a way to reproduce the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants