Feature - Local Timezones #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp saved in the database is UTC based on my testing and what I could find online. The SQLite documentation was a bit vauge around this. Since the timestamp being returned is already UTC I am just converting in the browser, since it will use the client's local timezone. I'va also adjusted things to format the timestamp in the browser instead of on the server. This is allowing us to take advantage of that conversion to local time
|
This should address #73 |
|
Definetively a good idea, but we could eventually use |
|
Yeah, that would definitely be an option. I completely forgot about, it is just harder to make things display a certain way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all times come through as UTC, but that is not friendly for less technical user. This update takes advantage of SQLite storing timestamps in UTC and adds the date-fns format function to the client to convert the timestamp to the display format in the browser. This results in the time coming through as the visitor's timezone, according to their system clock.