Docs #2
Merged
Docs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
added a commit
that referenced
this pull request
Dec 12, 2024
Otherwise I was getting this error:
```
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
error: could not compile `heroku-ruby-buildpack` (bin "heroku-ruby-buildpack") due to 1 previous error
⛄️ 3.3.1 🚀 /Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby (schneems/pub-traits)
$ RUSTFLAGS="-Zmacro-backtrace" cargo build
Compiling heroku-ruby-buildpack v0.0.0 (/Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby)
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
```
From this code:
```
try_migrate_deserializer_chain!(
chain: [MetadataV1, MetadataV2, MetadataV3],
error: MetadataMigrateError,
deserializer: toml::Deserializer::new,
);
```
Presumably because I was using 3 values instead of just 2.
schneems
added a commit
that referenced
this pull request
Dec 12, 2024
There's a bug in the macros where this code is missing a semicolon:
```
// Link B => C, and the rest
$crate::try_migrate_link!($b, $($rest),*)
```
It should be triggered by the code in this test but it's not.
It mimics this code from the Ruby buildpack:
```
try_migrate_deserializer_chain!(
chain: [MetadataV1, MetadataV2, MetadataV3],
error: MetadataMigrateError,
deserializer: toml::Deserializer::new,
);
```
Which triggers this error (backtrace courtesy of nightly) `RUSTFLAGS="-Zmacro-backtrace" cargo build`
```
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
error: could not compile `heroku-ruby-buildpack` (bin "heroku-ruby-buildpack") due to 1 previous error
⛄️ 3.3.1 🚀 /Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby (schneems/pub-traits)
$ RUSTFLAGS="-Zmacro-backtrace" cargo build
Compiling heroku-ruby-buildpack v0.0.0 (/Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby)
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
```
However, the current test compiles and runs just fine and I don't know why.
schneems
added a commit
that referenced
this pull request
Dec 12, 2024
Otherwise I was getting this error:
```
$ RUSTFLAGS="-Zmacro-backtrace" cargo build
Compiling heroku-ruby-buildpack v0.0.0 (/Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby)
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
```
From this code:
```
try_migrate_deserializer_chain!(
chain: [MetadataV1, MetadataV2, MetadataV3],
error: MetadataMigrateError,
deserializer: toml::Deserializer::new,
);
```
Presumably because I was using 3 values instead of just 2.
schneems
added a commit
that referenced
this pull request
Dec 12, 2024
Otherwise I was getting this error:
```
$ RUSTFLAGS="-Zmacro-backtrace" cargo build
Compiling heroku-ruby-buildpack v0.0.0 (/Users/rschneeman/Documents/projects/work/buildpacks-ruby/buildpacks/ruby)
error: macros that expand to items must be delimited with braces or followed by a semicolon
--> /Users/rschneeman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magic_migrate-0.2.0/src/lib.rs:437:34
|
419 | macro_rules! try_migrate_link {
| ----------------------------- in this expansion of `$crate::try_migrate_link!` (#3)
...
437 | $crate::try_migrate_link!($b, $($rest),*)
| ^^^^^^^^^^^^^^^^
...
714 | macro_rules! try_migrate_deserializer_chain {
| -------------------------------------------
| |
| in this expansion of `try_migrate_deserializer_chain!` (#1)
| in this expansion of `$crate::try_migrate_deserializer_chain!` (#2)
...
737 | $crate::try_migrate_link!($a, $($rest),+);
| ----------------------------------------- in this macro invocation (#3)
...
764 | $crate::try_migrate_deserializer_chain!(error: $err, deserializer: $deser, chain: [$a, $($rest),+]);
| --------------------------------------------------------------------------------------------------- in this macro invocation (#2)
|
::: buildpacks/ruby/src/layers/bundle_install_layer.rs:120:1
|
120 | / try_migrate_deserializer_chain!(
121 | | chain: [MetadataV1, MetadataV2, MetadataV3],
122 | | error: MetadataMigrateError,
123 | | deserializer: toml::Deserializer::new,
124 | | );
| |_- in this macro invocation (#1)
```
From this code:
```
try_migrate_deserializer_chain!(
chain: [MetadataV1, MetadataV2, MetadataV3],
error: MetadataMigrateError,
deserializer: toml::Deserializer::new,
);
```
Presumably because I was using 3 values instead of just 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.