small improvements on ML docu notebooks #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daslu
approved these changes
Jan 25, 2025
notebooks/noj_book/automl.clj
Outdated
| ;; The `model` function has closed over the id, so is knows "his id", so in the `transform` | ||
| ;; mode it can get the data created at `:fit`. So the `model` function can "send" data to itself | ||
| ;; from `:fit` to `:transform`, the `trained model`. | ||
| ;; The `model` function has closed over the id, so is knows "its id", so in the |
There was a problem hiding this comment.
Great explanation.
Just noticed a small typo:
so is knows -> so it knows
notebooks/noj_book/metamorph.clj
Outdated
| @@ -287,19 +288,23 @@ | |||
| (mm/lift str/reverse) | |||
| (mm/lift first))) | |||
|
|
|||
| ;; The lifting creates a vriant of te original function which acts on the | |||
notebooks/noj_book/metamorph.clj
Outdated
| @@ -287,19 +288,23 @@ | |||
| (mm/lift str/reverse) | |||
| (mm/lift first))) | |||
|
|
|||
| ;; The lifting creates a vriant of te original function which acts on the | |||
| ;; data in te context under key :metamparph/data | |||
|
fixed the spelling mistakes you saw |
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.